search

openfl / openfl-html5

[deprecated] OpenFL HTML5 backend
Other
0 stars 1 forks source link

Some fixes #15

Closed jgranick closed 10 years ago

jgranick commented 10 years ago

15 Issue by dimanux,

jgranick commented 10 years ago

Comment by jgranick:

Hey!

Thanks for the patches and improvements. I've integrated the following directly:

I believe I manually patched an error case you fixed in the Rectangle __expand function, so at the moment, I can't see a difference in function between your version and the current one, so I've left it.

I add the REMOVE_FROM_STAGE events, and updated __renderable to not include alpha, so that the dimensions/transform of invisible (but still "substantial") objects are done.

I'm not sure if we should have the Lib.preventDefaultTouchMove event, I don't like stuffing stuff in the Lib function. I already disabled the default behavior for "touchmove" on the application element, so if you're fullscreen, I think you're covered? If this isn't the case, let me know. We might consider doing this in the default HTML template, instead of being baked in as a command like this.

I recently added scrollRect support, so please give it a try and let me know how it goes for you.

I also included Capabilities among other classes, so that should be done already.

I also tried to solve the "getBounds" call differently, but modifying __getBounds for DisplayObjectContainer to work more like your code, rather than the previous behavior. If you would, I would love if you gave it a try and saw if it resolved it for you, still. Thanks!