search

openfl / starling

Known as the "Cross-Platform Game Engine", Starling is a popular Stage3D framework for OpenFL and Haxe
Other
236 stars 67 forks source link

Fix RenderTexture dispose() texture #111

Closed Doppp closed 6 years ago

Doppp commented 6 years ago

From Haxegon, _activeTexture was being disposed twice once in RenderTexture and once in SubTexture. Only dispose it in RenderTexture if SubTexture isn't going to dispose it.

TerryCavanagh commented 6 years ago

Ah, yep - this bug was found by @mrcdk!

mrcdk commented 6 years ago

Oh, yeah. I was waiting for some more testing before making a PR here just in case but, so far, the issue we were having hasn't appeared again so I guess this PR won't cause any issues 😅

peteshand commented 6 years ago

I'd suggest making the same PR on the as3 Starling repo, just to keep the behaviour the same. https://github.com/Gamua/Starling-Framework/blob/master/starling/src/starling/textures/RenderTexture.as

Doppp commented 6 years ago

Sure, I've done it here, @peteshand. https://github.com/Gamua/Starling-Framework/pull/1043

jgranick commented 6 years ago

Does Flash allow you to dispose twice? Is this an issue with OpenFL's implementation of dispose?

Doppp commented 6 years ago

@jgranick I changed it to remove the dispose call. AS3 Starling has already merged that into their repo. Refer to: https://github.com/Gamua/Starling-Framework/pull/1043#issuecomment-420265029. @mrcdk maybe we can remove that dispose call in Haxegon instead.

mrcdk commented 6 years ago

No, that's not a good change, if you change the _owsParent value with https://github.com/openfl/starling/blob/ecd20019e99463168e8c65e3d2fbb2f08ef3cf54/src/starling/textures/SubTexture.hx#L81(it's an internal call but still, we can't be 100% sure it won't happen) you risk disposing the _activeTexture twice.

Doppp commented 6 years ago

@mrcdk PrimaryFeather went further to check for the correct texture to dispose: https://github.com/Gamua/Starling-Framework/commit/dea6e34b057add5a9fa1ef1629dded2852ea6541 Any thoughts?