Support for CSS3-style color, rgb() and rgba()

openfl / svg

Provides SVG parsing and rendering for OpenFL and Haxe

MIT License

68 stars 30 forks source link

Support for CSS3-style color, rgb() and rgba() #34

Closed jcward closed 8 years ago

jcward commented 8 years ago

An implementation of css-style color support, e.g. rgb(255,0,0), for fill and stroke colors.

while rgba isn't technically part of the standard, it seems to be supported by browsers, gimp, etc
I didn't (yet) implement the % format, rgb(100%,50%,0)

jcward commented 8 years ago

huh, I appear to have branched this from the 3-char fix. Sorry.

ashes999 commented 8 years ago

I'm hesitant to support anything that's not part of the standard. At the very least, it'll make generating the "expected" unit test image complicated.

Do you mind removing that part, and adding test cases for this? Please comment on this PR when you're done.

I merged in the 3-char change, so you're cool as far as branching goes.

jcward commented 8 years ago

I'm going to submit a new request with just rgb and the % values. Closing this one.

ashes999 commented 8 years ago

Thanks, I really appreciate it.