Closed ashes999 closed 8 years ago
Code review please? @jcward @gama11
Looks good to me.
Please review @ibilon
Looks like I merged this in by mistake. It still needs a review.
According to https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/transform rotate(<a> [<x> <y>])
is equivalent to translate(<x>, <y>) rotate(<a>) translate(-<x>, -<y>)
but here the translate are in the other order.
Also the x,y
parameters should be optional, "If optional parameters x and y are not supplied, the rotate is about the origin of the current user coordinate system."
I'll take a look at this next week.
Sorry to get the formula wrong. I reverse-engineered it (didn't think the SVG spec would mention it) from highschool algebra (move to origin, rotate, and move back).
Please review the untranslate/retranslate code. I hope I got my algebra right (it's been a while ...)