Closed zhouzhuojie closed 3 years ago
Merging #35 (0f17204) into main (f161c56) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## main #35 +/- ##
=======================================
Coverage 81.55% 81.55%
=======================================
Files 27 27
Lines 2174 2174
=======================================
Hits 1773 1773
Misses 314 314
Partials 87 87
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f161c56...0f17204. Read the comment docs.
Description
To make sure that the distribution result from eval flags are as close as expected with the hashing function that flagr is using (i.e. CRC32). In these tests, we are targeting 1e6 samples and a 0.5% error bar (usually it's less than 0.1%, e.g. 0.0436% from the secure random key generator, but for reducing the flakiness of unit tests, we are raising the threshold to 0.5%).
Motivation and Context
Address some of the concerns raised from https://github.com/checkr/flagr/issues/464
How Has This Been Tested?
unit tests
Types of changes
Checklist: