openflagr / flagr-archived

[Archived] - Merged and move to https://github.com/openflagr/flagr
https://openflagr.github.io/flagr
Apache License 2.0
33 stars 7 forks source link

Adding support for Webhooks #38

Closed sorenmat closed 2 years ago

sorenmat commented 2 years ago

Description

Adding a webhook for notifying other services when a change happens in flagr.

Pretty much a copy of #410 which seems to be stale. Simplified it a bit and removed the slack portion of it, since there seems to be some discussions on how to implement that in a sane way.

After this is merged we can rebase #410 and get the slack notification going

Motivation and Context

Useful for keeping an audit style log in another system

How Has This Been Tested?

By running the test suite, and done manual testing locally

Types of changes

Checklist:

marceloboeira commented 2 years ago

I'm going to look into how to test this with integration testing so that we can be more sure it works as expected and continuously get supported throughout time.

sorenmat commented 2 years ago

This sovled #30 btw :)

github-actions[bot] commented 2 years ago

Stale pull request message

sorenmat commented 2 years ago

@marceloboeira did you look at the integration tests, or should I take a crack at it?

github-actions[bot] commented 2 years ago

Stale pull request message