Closed marceloboeira closed 2 years ago
Stale issue message
@zhouzhuojie any word on this?
Stale issue message
Can someone educate me on the thoughts behind having a GitHub action to automatically close issues and pull-requests? Looking back through the closed items, there appears to be a lot of work done by volunteers which was seemingly ignored. I completely understand that people get busy and projects get stale, but having the issues and pull-requests stay open would give people who are: 1) evaluating the project and 2) considering forking the project, a better idea of the project state and what can be pulled into a fork of the project.
The uniqueness constraint of
flag.key
is a known part of flag. Validation errors that rely on client-logic (uniqueness of a field) is responsibility of the client to implement, thus the server should return a 400-ish (e.g.: 400 Bad Request, 406 Not Acceptable, ...) and not a 500 Internal Server Error, since that is not the case.Using httpie to exemplify:
If you try that again, you should get something like...
Expected Behavior
But you end up getting a 500:
Current Behavior
Possible Solution
Intercept this uniqueness constraint error and fail gracefully
Steps to Reproduce (for bugs)
See above...
Context
Semantically, validations errors should be client errors, 400-ish, since the server doesn't fail, yet the client fails on trying to bypass the uniqueness of the field.
Your Environment
flagr version
): 1.1.13uname -a
):Helsinki.local 20.6.0 Darwin Kernel Version 20.6.0: Mon Aug 30 06:12:21 PDT 2021; root:xnu-7195.141.6~3/RELEASE_X86_64 x86_64