Closed fenriskiba closed 2 years ago
@zhouzhuojie or @marceloboeira would one of you be able to review this?
Is there a way to rerun the ci / unit_test suite? It seems like it timed out, but I can't see any reason why it would and it runs fine in my local. I'm wondering if it just got caught on a network issue or something.
@fenriskiba I haven't had the time yet to review this, I'll take a look later this week. In any case, I just re-triggered the jobs to see if it works now
yes, let's separate the docker image bump from Kafka config changes, easy to revert if needed. thank you!
Merging #45 (5f19115) into main (f6a8dd2) will increase coverage by
0.01%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #45 +/- ##
==========================================
+ Coverage 81.55% 81.57% +0.01%
==========================================
Files 27 27
Lines 2174 2176 +2
==========================================
+ Hits 1773 1775 +2
Misses 314 314
Partials 87 87
Impacted Files | Coverage Δ | |
---|---|---|
pkg/handler/data_recorder_kafka.go | 73.14% <100.00%> (+0.50%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f6a8dd2...5f19115. Read the comment docs.
pending on @marceloboeira
Resolving Issue #21
Description
Motivation and Context
See Issue #21
How Has This Been Tested?
Manually regression and stress tested in our OpenShift environment, both with default Kafka configs and Idempotency enabled.
Types of changes
Checklist: