Closed glutamatt closed 2 years ago
Merging #46 (16b6fa3) into main (1694d8e) will increase coverage by
2.18%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## main #46 +/- ##
==========================================
+ Coverage 81.55% 83.74% +2.18%
==========================================
Files 27 28 +1
Lines 2174 2356 +182
==========================================
+ Hits 1773 1973 +200
+ Misses 314 299 -15
+ Partials 87 84 -3
Impacted Files | Coverage Δ | |
---|---|---|
pkg/entity/logger.go | 46.66% <0.00%> (ø) |
|
pkg/handler/eval.go | 87.09% <0.00%> (+0.31%) |
:arrow_up: |
pkg/handler/crud.go | 91.55% <0.00%> (+5.33%) |
:arrow_up: |
pkg/handler/data_recorder_kafka.go | 79.54% <0.00%> (+6.90%) |
:arrow_up: |
pkg/handler/export.go | 73.17% <0.00%> (+9.40%) |
:arrow_up: |
pkg/entity/db.go | 88.52% <0.00%> (+14.23%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 1694d8e...16b6fa3. Read the comment docs.
Stale pull request message
thanks @zhouzhuojie for this merge and the whole work on flagr i work at deezer.com and your project is insanely useful
Description
a quick and dirty patch to respect flagr api when updating distributions
Motivation and Context
How Has This Been Tested?
i tried the ui, by hand, checked the http request with chrome dev tool, in a dev env in my company
Types of changes
Checklist: