openflagr / flagr-archived

[Archived] - Merged and move to https://github.com/openflagr/flagr

https://openflagr.github.io/flagr

Apache License 2.0

33 stars 7 forks source link

no root user + docker ignore dockerfile #52

Closed glutamatt closed 2 years ago

glutamatt commented 2 years ago

Description

security recommendations are to avoid root in containers

Motivation and Context

How Has This Been Tested?

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

zhouzhuojie commented 2 years ago

thanks, let's also change this file https://github.com/openflagr/flagr/blob/main/integration_tests/Dockerfile-Integration-Test

glutamatt commented 2 years ago

thanks, let's also change this file https://github.com/openflagr/flagr/blob/main/integration_tests/Dockerfile-Integration-Test

done

codecov-commenter commented 2 years ago

Codecov Report

Merging #52 (cc3cbfe) into main (1694d8e) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #52   +/-   ##
=======================================
  Coverage   81.55%   81.55%           
=======================================
  Files          27       27           
  Lines        2174     2174           
=======================================
  Hits         1773     1773           
  Misses        314      314           
  Partials       87       87

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1694d8e...cc3cbfe. Read the comment docs.