Add JWKS Support - Githubissues

openflagr / flagr-archived

[Archived] - Merged and move to https://github.com/openflagr/flagr

https://openflagr.github.io/flagr

Apache License 2.0

33 stars 7 forks source link

Add JWKS Support #62

Closed vodzak closed 2 years ago

vodzak commented 2 years ago

Description

Adding support for JWKS when using JWT auth.

Motivation and Context

In order to add JWKS support to Flagr's existing JWT auth flow, the JWT middleware library was replaced with lestrrat-go/jwx. jwx was preferred over the library originally used due to the breaking changes it had listed, as well as changes in functionality (ex: requires JWT to have kid field).

How Has This Been Tested?

JWT Auth (Existing Functionality)
- Locally tested via Postman.
JWKS JWT Auth (New Functionality)
- Locally tested via Postman and tested in OpenShift.
General regression testing via Postman.
Flagr's unit tests.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I have added tests to cover my changes.
[X] All new and existing tests passed.

github-actions[bot] commented 2 years ago

Stale pull request message