search

openflagr / flagr

Flagr is a feature flagging, A/B testing and dynamic configuration microservice
https://openflagr.github.io/flagr
Apache License 2.0
2.43k stars 185 forks source link

Evaluations being recorded to Kafka multiple times #463

Closed fenriskiba closed 2 years ago

fenriskiba commented 3 years ago

Evaluations sent through the Kafka Recorder are getting duplicated intermittently.

Expected Behavior

Each evaluation should have a single message sent to Kafka.

Current Behavior

Approximately 0.65% (sampled from roughly 6 million Kafka messages) of evaluations are recorded to Kafka 2 or more times.

Steps to Reproduce (for bugs)

  1. Use Vegeta to produce about 2000 evaluations per second with randomly generated entity IDs for about 15 minutes
  2. Use the Sarama example apps (with some minor formatting adjustments) to consume the generated messages in Kafka and pipe the results into a CSV
  3. Identified multiple identical payload messages in the CSV

Context

Creates some confusion/misleading conclusions if someone doesn't know to dedup data when doing analysis on an AB Test.

Your Environment

zhouzhuojie commented 3 years ago

https://github.com/openflagr/flagr/issues/21#issuecomment-894709420

github-actions[bot] commented 2 years ago

Stale issue message