openflighthpc / carbon-leaderboard

A tool to compare environmental impact data from different systems

0 stars 0 forks source link

Navbar Beautify & Minor improvements #5

Closed Cena-Studio closed 2 months ago

Cena-Studio commented 2 months ago

Overview

This PR mainly adds styles to the navbar.

Major Changes

Add styles to the dropdown list.
The dropdown list will be expanded by hovering the mouse instead of clicking.
Include the logo text OpenFlightHpc carbon leaderboard in the link back to the home page.
Fix the incorrect emission per core calculation algorithm in the backend.

Minor Changes

Tweaked/Uniformed the background style of the navbar and the leaderboard's header.
Adjusted the glow bar of the leaderboard item. It will now glow stronger/brighter than the default state when the mouse is hovering.

megan-godfrey commented 2 months ago

LGTM! :)

Womblue commented 2 months ago

Currently, when you log in or out of an account, you are always redirected back to the homepage. Could part of this PR be changing that so you're redirected to the page you were on when you pressed the log in/out button?

Cena-Studio commented 2 months ago

Currently, when you log in or out of an account, you are always redirected back to the homepage. Could part of this PR be changing that so you're redirected to the page you were on when you pressed the log in/out button?

The login logic will be remastered in the next PR. Actually I don't want devise to automatically redirect. Will look at this later.

Womblue commented 2 months ago

Alright, it's not an urgent change but it's something on my list. With the new user pages we've got in 0.0.2, it feels quite unintuitive to go to your page, see that you're not logged in, and then be directed away from your page again after logging in to your account.