Closed benarmston closed 7 months ago
Is it worth noting the startup race condition in the list of "things that could be improved"? Could possibly be resolved with a Docker healthcheck definition on the visualisation
container coupled with depends_on
/condition
declarations for the relevant services?
EDIT: That's now covered by #86.
I'm going to merge this to main
. It works just fine for me. The documentation can be enhanced for those using VSCode and developing directly on their laptops, but I will leave that up to such users.
--debug
.RAILS_ENV=development
.air
.debug=True
as an argument todriver.py
could be made to work for some of them.Things that could still be improved:
docker-compose.dev.yml
file needs to be merged intodocker-compose.yml
.proxy
container. Currently, its not obvious how one would change the nginx configuration and have that picked up by theproxy
container. Perhaps that's just a documentation issue, or perhaps we want a better process here too.provision-ben.sh
,provision-tim.sh
etc..