Closed timalces closed 8 months ago
A couple of comments on this. Otherwise it looks OK. (Running through a build using this now).
Should we be adding a password for the redis server? Or is the data it contains not sufficiently important.
If a password is required, it could be added to the password generation in https://github.com/alces-flight/concertim-ansible-playbook/blob/main/ansible/roles/concertim_common/tasks/main.yaml and to the environment file template at https://github.com/alces-flight/concertim-ansible-playbook/blob/main/ansible/roles/concertim_common/templates/secrets.env.
Sounds sensible to have one, thanks - have added.
This LGTM.
Linked to https://github.com/alces-flight/concertim-ct-visualisation-app/pull/108
redis_ip
can optionally be configured inansible/group_vars/all
andredis_port
&redis_interface
configured inansible/etc/globals.yaml