search

openflighthpc / flight-desktop

Manage interactive GUI desktop sessions
Eclipse Public License 2.0
0 stars 2 forks source link

Don't use -rfbwait if running RHEL 8 #54

Closed VoxSecundus closed 2 years ago

VoxSecundus commented 2 years ago

The TigerVNC package on Centos 7 has support for an option called -rfbwait, which we use in libexec/vncserver. The TigerVNC package on Centos 8 has since removed support for this option. This PR only changes the Xvnc call to omit the -rfbwait option if the system is running RHEL 8.

We may be able to remove the option entirely, but I'm not sure what it does so I'll leave that decision to someone who does.

mjtko commented 2 years ago

Looks:

  rfbwait        - Alias for ClientWaitTimeMillis
[...]
  ClientWaitTimeMillis - The number of milliseconds to wait for a client which
                   is no longer responding (default=20000)

I assume that under the EL8 Xvnc, ClientWaitTimeMillis continues to exist with a default of 20000, which seems close enough to the 30000 we've used under EL7. Even if not, based on what it's for (nothing particularly critically), not using it when it's not there SGTM.