search

openfoodfacts / openfoodfacts-androidapp

Native version of Open Food Facts on Android - Coders & Decoders welcome 🤳🥫
https://android.openfoodfacts.org
Apache License 2.0
754 stars 444 forks source link

Implement MaterialTheme #3755

Open VaiTon opened 3 years ago

VaiTon commented 3 years ago

Steps

kartikaysharma01 commented 3 years ago

There are two options for us to make app theme to inherit from a Material Components theme :-

  1. Bridge Themes
  2. AppCompat Themes

I personally would suggest 1. @VaiTon Views?

VaiTon commented 3 years ago

There are two options for us to make app theme to inherit from a Material Components theme :-

1. [Bridge Themes](https://github.com/material-components/material-components-android/blob/master/docs/getting-started.md#bridge-themes)

2. [AppCompat Themes](https://github.com/material-components/material-components-android/blob/master/docs/getting-started.md#appcompat-themes)

I personally would suggest 1. @VaiTon Views?

I would start with bridge themes, and them move to extending the MaterialComponents theme. We already follow a lot of material guidelines so why not just using the theme and extending it.

kartikaysharma01 commented 3 years ago

I agree.

teolemon commented 2 years ago

@VaiTon Is that already done ?

VaiTon commented 2 years ago

@VaiTon Is that already done ?

We need to extend MaterialComponents theme to close this issue