search

openfoodfacts / openfoodfacts-androidapp

(Legacy) Native version of Open Food Facts on Android - Coders & Decoders welcome 🤳🥫
https://android.openfoodfacts.org
Apache License 2.0
767 stars 446 forks source link

Attributes don't show up for Hebrew (RTL) #4250

Open teolemon opened 2 years ago

teolemon commented 2 years ago

What

Part of

Screenshot

image

yarons commented 2 years ago

Also the downwards arrows should be aligned to the left instead of to the right.

mcarare commented 2 years ago

This does not look like an RTL issue, rather the attributes are empty for the selected language.

yarons commented 2 years ago

@mcarare Hebrew translation in Crowdin is 99% complete, the remaining strings are mostly links so it's probably not related, anything I should translate further? Anything that should be changed elsewhere?

BTW there is an additional RTL problem, the downwards arrow are to the right instead of to the left.

mcarare commented 2 years ago

@yarons Not sure if it is a translation problem or the problem is in the code here: https://github.com/openfoodfacts/openfoodfacts-androidapp/blob/ba334af496d6017c7e33afae60cb94521a925d32/app/src/main/java/openfoodfacts/github/scrachx/openfood/models/Product.kt#L370. It needs to be investigated further because the name is returned as an empty string. But attributes not showing it is not an RTL issue.

yarons commented 2 years ago

It's weird because this is an iterative function and there are several items on screen, maybe the font is at the same color as the background or something like that?