search

openfoodfacts / openfoodfacts-androidapp

(Legacy) Native version of Open Food Facts on Android - Coders & Decoders welcome 🤳🥫
https://android.openfoodfacts.org
Apache License 2.0
767 stars 446 forks source link

Coordinates are lost on rotation in Edit Mode photo edit #4578

Open teolemon opened 2 years ago

teolemon commented 2 years ago

What

Steps to reproduce the behavior

  1. Go to Edit mode
  2. Click on the small ingredients photo in the ingredient tab
  3. Crop it
  4. Rotate it
  5. Coordinates are lost

https://user-images.githubusercontent.com/1689815/159354713-4a1d55a2-b6b1-4f13-bbd8-529a667c8466.mp4

g123k commented 2 years ago

We use a really, really old version of the image cropper library (3.1.3 in our app vs 4.1.0) https://github.com/CanHub/Android-Image-Cropper/releases

Migrating to the latest version requires some changes on our side (from the old startActivityResult to the new registerForActivityResult)

Is it worth spending time on this?

teolemon commented 2 years ago

No, you're right.