search

openfoodfacts / openfoodfacts-androidapp

(Legacy) Native version of Open Food Facts on Android - Coders & Decoders welcome 🤳🥫
https://android.openfoodfacts.org
Apache License 2.0
767 stars 447 forks source link

Use the Google Play "In-App-Review" API #4600

Open g123k opened 2 years ago

g123k commented 2 years ago

Instead of opening Google Play to rate the app, we should use the embedded API "In-App-Review": https://developer.android.com/guide/playcore/in-app-review

iar-flow

Note: Only Google Play variants should implement this

lailajs commented 2 years ago

could I tackle this? Thanks!

g123k commented 2 years ago

You can take it @lailajs (my students won't have the time to work on it today)

g123k commented 2 years ago

Any news @lailajs?

lailajs commented 2 years ago

Yes! I’ll be working on it this week as part of a school project. Thank you

On Fri, Apr 8, 2022 at 4:51 PM Edouard Marquez @.***> wrote:

Any news @lailajs https://github.com/lailajs?

— Reply to this email directly, view it on GitHub https://github.com/openfoodfacts/openfoodfacts-androidapp/issues/4600#issuecomment-1093353805, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANIXDCWPOQ2G72SRL27N44DVECL5PANCNFSM5RO2BLMA . You are receiving this because you were mentioned.Message ID: @.***>

lailajs commented 2 years ago

hey @g123k, im looking through the repo code, and was wondering if you have any ideas of where the best place to implement this feature is. Thank you so much!

g123k commented 2 years ago

It's already implemented in the app. In the MainActivity, you have the showFeedbackDialog method, which is called on a user is logged in

lailajs commented 2 years ago

ohh okay I see! So what exactly is my task then? the current code makes the user leave the app right?

g123k commented 2 years ago

The current code doesn’t use the Rating API from the Google Play. That’s the change required in this issue

lailajs commented 2 years ago

Yes, I see. Just to make sure, the current code redirects the user to the google play store, right? Im a beginner in Kotlin and just want to make sure!

g123k commented 2 years ago

Yes. You should test the app, you will how the workflow works

lailajs commented 2 years ago

Do you know if its possible to run the android version on my iphone? i dont have any android devices, and I'm not sure how to run the app without one

g123k commented 2 years ago

There is an emulator on Android, directly available on Android Studio

lailajs commented 2 years ago

its so weird, when i run the app it only runs open beauty facts.. not open food facts, does that happen for you?

g123k commented 2 years ago

I don't want to offense you, but regarding your questions I suggest you to take some time to learn the basics of the Android programming