search

openfoodfacts / openfoodfacts-androidapp

(Legacy) Native version of Open Food Facts on Android - Coders & Decoders welcome 🤳🥫
https://android.openfoodfacts.org
Apache License 2.0
771 stars 447 forks source link

Add suitable icons in `Preferences` #4902

Closed pratyaksh1610 closed 6 months ago

pratyaksh1610 commented 1 year ago

What

Add suitable icons in Preferences.

Why/User story

Add suitable icons in Preferences for better UI.

Before

off

gaurisharma1122 commented 1 year ago

Hi @teolemon , I want to work on this.

dmdbilal commented 1 year ago

Can I work on this issue ?

memms commented 1 year ago

I see the previous pull request for the issue was closed instead of merged. Is this issue still open to be worked on? If so, is there a requirement for icon choices (a drive with the SVG files per se)?

its-me-abhishek commented 1 year ago

@teolemon If possible, can you please assign this issue to me . I want to work on this.

its-me-abhishek commented 1 year ago

@teolemon If possible, can you please assign this issue to me . I want to work on this.

  • As I have noticed, another PR was closed as the OP had used png file format.
  • I will be implementing the icons using the svg file format using either the free open-source Google Fonts icons / or any other icon pack as suggested.
  • Another issue that I have observed from the above PRs is the inconsistency in the thickness of the icons. Will be looking forward for a set of equally formatted icons.

Following are the samples of the icons that we will be implementing: Theme

Preferred Energy Unit

Preferred Volume Unit

Delete Local Search History