Closed moshpirit closed 7 years ago
We already provide that when it's on the packaging. See http://world.openfoodfacts.org/product/3041090001864/lait-gallia-calisma for instance.
But the table doesn't appear on the Android app, just the ingredients and "Nutrient levels for 100 g" :(
Yes, I didn't implement it yet
OK, then I leave the issue open :) thanks a lot for this great service!
@itchix does this information should be displayed in another tab ? or in the nutrition tab, after the nutritional mark ?
I think a new tab is the best, the nutrition tab must be clear. You can add like "Advance nutrition" tab, @teolemon what do you think?
Maybe a button at the bottom like "view advanced nutrition" with the information that unfolds ?
@teolemon What do you think about that? You can click on the image and then zoom it.
I don't know if it's a good thing to show the entire table because some phone have a small screen. Display the data may be a little bit small on the screen. @herau Any idea for the UI?
@itchix i like your UI idea. maybe with color level indicator like with 5c.a table is maybe a little bit too simple and austere.
Here's the current version
Currently nutriments are not grouped by Fat / Carbohydrate / Proteins / Salt etc (in the API)
So it's complicated to create the same table than in the current open food app.
The logic for the table is available in the Food.pm file. It changes from country to country. Also available are the full text name of the nutrients plus translations.
On Wed, Dec 7, 2016 at 3:14 PM Aurélien Leboulanger < notifications@github.com> wrote:
Currently nutriments are not grouped by Fat / Carbohydrate / Proteins / Salt etc (in the API)
So it's complicated to create the same table than in the current open food app.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openfoodfacts/OpenFoodFacts-androidApp/issues/99#issuecomment-265457081, or mute the thread https://github.com/notifications/unsubscribe-auth/ABnI14VrTUFpVlNOo4wfLX8gZeDQvYACks5rFr8pgaJpZM4IpPm- .
ok so we have to define a grid per region (Europe, US, Catalan, Russia) i guess. But we have to group locale by region to handle the right grid display
let's stick to one grid, we'll customize later
could be great if you can have sub-division like in the current official OFF app. But currently the API doesn't provide this kind of hierarchy and i think that the division is different per country isn't it @teolemon ?
I propose that we copy the structure for English from the web version, and localize later (Search is not localized, and the rest of the product page like ingredient list isn't)
Here's a nice example of what subdivisions could look like:
Something like: calcium, iron, proteins (what amino acids), vitamins (A, C, …), omega (3, 6,…), etc