Problem with offline message in Dutch - Githubissues

openfoodfacts / openfoodfacts-ios

Native (Swift) version of Open Food Facts for iOS. Coders & Decoders welcome 🤳🥫 😊

https://ios.openfoodfacts.org

Apache License 2.0

359 stars 159 forks source link

Problem with offline message in Dutch #308

Closed teolemon closed 5 years ago

teolemon commented 5 years ago

teolemon commented 5 years ago

Dutch, Belgium (nl_BE) 1.5 Dutch, Netherlands (nl_NL) 1.5

teolemon commented 5 years ago

Capture d’écran 2019-06-21 à 18 26 24

teolemon commented 5 years ago

https://github.com/openfoodfacts/openfoodfacts-ios/blob/master/Sources/nl.lproj/Localizable.strings https://github.com/openfoodfacts/openfoodfacts-ios/blob/master/Sources/Localization/nl.lproj/Localizable.strings

teolemon commented 5 years ago

The canonical Crowdin file is:

source: /Sources/en.lproj/Localizable.strings translation: /Sources/Localization/%two_letters_code%.lproj/Localizable.strings

aleene commented 5 years ago

Which means the string is not listed in Localizable strings.

teolemon commented 5 years ago

I'm currently resyncing with 2 files for nl, instead of one. Is your phone in nl or nl-be ?

aleene commented 5 years ago

nl-nl The string does not seem available on Crowdin.

aleene commented 5 years ago

The strings are not available in localizable.strings. If I add them by hand everything is OK. I can push this change to master if you want.

aleene commented 5 years ago

It is only an issue the the dutch file. The others are OK.

By the way what is wrong with Mongo?

teolemon commented 5 years ago

I've updated some template on Crowdin, I'm curious to see if this fixes the bug. Did I say a thing about Mongo ?

aleene commented 5 years ago

No I did. The localizable Mongo-strings are very strange

aleene commented 5 years ago

This can be closed?