Closed teolemon closed 4 years ago
Max Bredow 3 hours ago The only major thing I came across was adding a photo of the ingredients. This cropping tool somehow crashes the app
Pierre Slamich 3 hours ago what happens if you donât crop ?
If I donât crop itâs fine If I add a pic when having scanned the item itâs fine But when finding the item (eg through the history) and then deciding to edit and crop, it crashes
I do get to âreproduceâ a problem : history > product > edit > âphoto of the ingredientsâ > take picture > crop > validate > app is stuck in a weird UI state (see below screenshot)
It seems a corresponding issue comes from the Crop dependency: https://github.com/TimOliver/TOCropViewController/releases A visual glitch that would occur in iOS 13 because the Swift view controller wasn't explicitly marked as full screen. (#385)
Trying with an update of the lib
(based on the ui, it seems that the front controller is here but âhiddenâ or ânot displayedâ)
Wrong path, updating the dependency did not fix anything.
@teolemon The problem is fixed using navVC.modalPresentationStyle = .fullScreen
in SummaryFooterCellController.swift
line 61
. This is only a workaround as the view is now displayed full screen, not in the new (nice) way of iOS 13.
thanks a lot for the analysis. @aleene @philippeauriach let's go for the workaround, and submit final to Apple ?
I works for me on iOS 12. thanks @philippeauriach for the workaround đ
When editing a product, after I crop the image of ingredients, the sheet becomes unresponsive and I get kicked out of this view. After that, when I go back into editing mode, the NutriScore is still there but the nutrients that I just had added, are empty
Max B.