openfoodfacts / openfoodfacts-ios

Native (Swift) version of Open Food Facts for iOS. Coders & Decoders welcome 🤳🥫 😊
https://ios.openfoodfacts.org
Apache License 2.0
361 stars 160 forks source link

Layout issue in the Summary tab on the iPhone 5S #714

Open teolemon opened 4 years ago

teolemon commented 4 years ago
tejuamirthi commented 3 years ago

Hey @teolemon what's the expected outcome for this? Like we can't always show the complete brand name if it's long. Let me know ur thoughts. I can fix the constraints!

aleene commented 3 years ago

Shall we put the name and brand below the images. Note that the ecoscore needs to be added as well.

tejuamirthi commented 3 years ago

That could work well! Below the image @aleene Where should the store go? More info or any ticket on that?

aleene commented 3 years ago

Put the name and brand next each other (multiline).

tejuamirthi commented 3 years ago

Okay @aleene , so now the order of UI elements becomes

Just clarifying in these terms to avoid any further confusions.

Please assign this issue to me so I can start working. Thanks in advance

tejuamirthi commented 3 years ago
Screenshot 2020-10-04 at 12 18 41 PM

Hey @aleene here when ther's no nutriscore and it is perfect from the current implementation. If I'm making the brand and quantity as a multiline part of the name. There'd be a huge gap when there's no nutriscore. So please confirm this once

aleene commented 3 years ago

This is nice, maybe convert the product name ti multiline?

tejuamirthi commented 3 years ago

Hey @aleene #686 is a part of the issue mentioned here. A solution was proposed there to follow how android does it. Should we proceed with that?

aleene commented 3 years ago

Looks good

aleene commented 3 years ago

Which ones do you want to hide. We are just rearranging?

tejuamirthi commented 3 years ago

Okay that was my bad for that. It was a confusion from my side. We are just rearranging. I'll make it multiline and share the screenshot for confirmation.