Offline mode photo upload deletes product categories, and switches to English

[teolemon]

Summary:

There's an issue when uploading pictures to product page from the "products you added while offline" page of the iOS app

NB : il y a un toujours un bug avec le mode offline sur l'app, j'ai uploadé des photos ça a supprimé la catégorie du produit et ça l'a mis en langue "anglais" Tacite

NB: there is still a bug with the offline mode on the app, I uploaded photos that deleted the product category and put it in the 'English' language '' Tacite

Steps to reproduce:

Please provide detailed steps for reproducing the issue.

• Scan a new barcode to create a new product page from the app
• Add just one picture
  • Edit the new product page from internet (add category)
• Lose connection / turn on Airplane mode
  • Take more pictures
  • Go back online and upload the pictures you took from the app
  • The product page will be emptied, the category you added will be removed.

I had an offline product on the app, I uploaded it and it deleted the category
26 septembre 2020 à 15:16:44 CEST - tacite Données (Changement : lang) (Suppression : categories) -- Nutriments (Suppression : nutrition-score-fr) - (app)Contributed using: OFF app for iOS - v3.4.1 - user id: 4E0706B6-7BDB-43FA-BDA5-1E4F78AB21C1 - voir

https://world.openfoodfacts.org/product/8410066137022/heinz https://world.openfoodfacts.org/product/8410066137022/tomato-ketchup-offre-decouverte-heinz?rev=29

Expected behavior:

It shouldn't delete anything

Potential solution: We need to make sure:

• [ ] we check for empty category field
• [ ] we check if the app was offline when adding the product (we probably need to store it when adding offline products)

Device and iOS version:

OpenFoodFacts beta (TestFlight)

[teolemon]

J'ajouterais que c'est pénalisant aussi parce que depuis que j'ai l'app d'installée, donc depuis plus d'un an, j'ai les 2 mêmes produits coincés dans le "pending upload". Donc à chaque fois que j'upload avec le mode offline, ils se renvoient aussi.
faudrait que je delete et réinstalle l'app peut etre

I would add that it is also penalizing because since I have the app installed, so for over a year, I have the same 2 products stuck in the "pending upload". So every time I upload with offline mode, they also bounce back.
I would have to delete and reinstall the app maybe

[teolemon]

https://github.com/openfoodfacts/openfoodfacts-ios/blob/d17614627e955f890adea50a1a7bac148228307f/Sources/ViewControllers/Products/Search/ScannerViewController.swift#L651