Check PHP8 + add Phpstan + some improvment - Githubissues

openfoodfacts / openfoodfacts-php

PHP wrapper for Open Food Facts

https://packagist.org/packages/openfoodfacts/openfoodfacts-php

MIT License

58 stars 34 forks source link

Check PHP8 + add Phpstan + some improvment #35

Closed Benoit382 closed 2 years ago

Benoit382 commented 3 years ago

Check compatibility with PHP8
Update PHPunit
Add (PHPSstan)[https://github.com/phpstan/phpstan]
Add cs-fixer with local rule (feel free to update)
Improve some test (too many copy paste)
Say "What fucking code" and gitblame myself...

Ready for all comment|blame ;)

gherardobertini commented 3 years ago

Have you tried to add php 8.0 in travis?
I notice that I can't install the package because is stuck to psr/log ^1.0

Dwarfex commented 3 years ago

You could merge the PR https://github.com/openfoodfacts/openfoodfacts-php/pull/32 into your branch, and check if the Github Actions will run successfull.

Benoit382 commented 3 years ago

Have you tried to add php 8.0 in travis? I notice that I can't install the package because is stuck to psr/log ^1.0

I will check that.

Benoit382 commented 3 years ago

I pick all code from #32

Benoit382 commented 3 years ago

I think we should squash and merge, and create a new issues, with bump version + create Unit|Functional test and remove integration test

Dwarfex commented 2 years ago

@Benoit382 that works for me :)

Benoit382 commented 2 years ago

Some one can squash and merge ?