Closed epalmans closed 1 year ago
for information, an other PR have been created : https://github.com/openfoodfacts/openfoodfacts-php/pull/42
for information, an other PR have been created : #42
missed that one sorry. Great actually, but I guess we should first have an intermediate release with minimum php8.0.2 first (incl other dependency upgrades) …. because else we would lock out people on e.g. Laravel 9 running php8.0
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
Will close this as this is now a start for the Branch 0.3.x-dev for dropping <8.1
to support apps that require PHP8 as a minimum, the following dependencies needed to be bumped/widened:
[OT] also included: small fix to release file handle when
uploadImage()
failsWhen this PR is approved, I suggest we immediately tag and release as a new version (0.3.0) in order for the
openfoodfacts/openfoodfacts-laravel
repo to allow it to require it as a minimum, because that one is currently failing Laravel 9 support without this PR's changes (as addressed in https://github.com/openfoodfacts/openfoodfacts-laravel/issues/26).