openfoodfacts / openfoodfacts-php

PHP wrapper for Open Food Facts
https://packagist.org/packages/openfoodfacts/openfoodfacts-php
MIT License
58 stars 34 forks source link

chore!: Upgrade dependencies (dropping < PHP8) #44

Closed epalmans closed 1 year ago

epalmans commented 2 years ago

to support apps that require PHP8 as a minimum, the following dependencies needed to be bumped/widened:

[OT] also included: small fix to release file handle when uploadImage() fails

When this PR is approved, I suggest we immediately tag and release as a new version (0.3.0) in order for the openfoodfacts/openfoodfacts-laravel repo to allow it to require it as a minimum, because that one is currently failing Laravel 9 support without this PR's changes (as addressed in https://github.com/openfoodfacts/openfoodfacts-laravel/issues/26).

Benoit382 commented 2 years ago

for information, an other PR have been created : https://github.com/openfoodfacts/openfoodfacts-php/pull/42

epalmans commented 2 years ago

for information, an other PR have been created : #42

missed that one sorry. Great actually, but I guess we should first have an intermediate release with minimum php8.0.2 first (incl other dependency upgrades) …. because else we would lock out people on e.g. Laravel 9 running php8.0

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Dwarfex commented 1 year ago

Will close this as this is now a start for the Branch 0.3.x-dev for dropping <8.1