search

openfoodfacts / openfoodfacts-php

PHP wrapper for Open Food Facts
https://packagist.org/packages/openfoodfacts/openfoodfacts-php
MIT License
58 stars 34 forks source link

feat: 0.3.x dev - Update dependencies and PHP to 8.1 #47

Closed Dwarfex closed 4 months ago

Dwarfex commented 1 year ago

What

Screenshot

Fixes

45

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

teolemon commented 7 months ago

Can we merge?

scybulski commented 5 months ago

What's the status here? I've just run all the tests and they pass so the error might have been just a temporary api issue not related to this repository. And as a side note it's blocking a related package https://github.com/openfoodfacts/openfoodfacts-laravel/pull/43 from being updated to the recent Laravel,

DonatasIk commented 4 months ago

This needs to be merged. It's creating a bottleneck for the related packages.

Benoit382 commented 4 months ago

I launched the phpunit on my side, except this error : https://github.com/openfoodfacts/openfoodfacts-php/pull/47#discussion_r1583230170 all it's works

In this project, it's real difficult to update the code...

teolemon commented 4 months ago

@epalmans you need to reapprove since you requested changes

epalmans commented 4 months ago

@epalmans you need to reapprove since you requested changes

done. Changed:

After your review we may merge and tag it

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud