search

openfoodfacts / openfoodfacts-php

PHP wrapper for Open Food Facts
https://packagist.org/packages/openfoodfacts/openfoodfacts-php
MIT License
58 stars 34 forks source link

feat: force user agent #53

Closed Benoit382 closed 4 months ago

Benoit382 commented 4 months ago

What

Force the user agent Clean of the previous PR https://github.com/openfoodfacts/openfoodfacts-php/pull/49

Issues

https://github.com/openfoodfacts/openfoodfacts-php/issues/48

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

epalmans commented 2 months ago

be aware that this will introduce a breaking change. Not sure if forcing the useragent is really that important (no way to verify anyhow)?... if not, maybe revert this - or add as optional parameter at the end of the constructor?

If we keep it in, we'd need to tag it as 0.4.x (at least)