fix: Update API paths - Githubissues

openfoodfacts / openfoodfacts-ruby

Open Food Facts API Wrapper

MIT License

35 stars 11 forks source link

fix: Update API paths #96

Closed shivneelmistry closed 1 month ago

shivneelmistry commented 1 month ago

What

API paths were outdated causing the gem to fail
Some inconsistencies in logic

Fixes bug(s)

Upgraded from V0 to V2 for product api
Updated tocgi/countries.pl such that locale logic works
Removed method that wasn't consumed

Next Step(s)

Ensure there is logic handling errors
Later an upgrade from V2 to V3 will be needed
2/36 tests are skipped, need to verify if these are required

sonarcloud[bot] commented 1 month ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

teolemon commented 1 month ago

Congratulations on your first PR @shivneelmistry 🎉 thanks @nicolasleger