openfoodfacts / openfoodfacts-server

Open Food Facts database, API server and web interface - 🐪🦋 Perl, CSS and JS coders welcome 😊 For helping in Python, see Robotoff or taxonomy-editor
http://openfoodfacts.github.io/openfoodfacts-server/
GNU Affero General Public License v3.0
658 stars 388 forks source link

Fix issues to deploy /lang directory as-is in production #2705

Open stephanegigandet opened 4 years ago

stephanegigandet commented 4 years ago

This is a meta-bug to identify issues that need to be fixed if we want to deploy the /lang directory as-is in production, instead of hand picking files and copying them manually.

  1. Bad translations / Outdated translations

Texts have been translated in 2 ways:

Going forward, we probably need to standardize on using Crowdin for texts translation (as it's easier to update parts of the translations), but we first need to review the texts in OFF main languages.

e.g. compare those 2 pages:

  1. Broken links

The URLs of some pages in some languages have been translated. E.g. the /discover page is /decouvrir in French.

Some of those pages with translated names are in github (e.g. for French), but most are not (e.g. for German, in production, there are many files with translated names in /srv/off/lang/de/texts that are not in github). Some are in github but are broken (e.g. https://es.openfoodfacts.org/contribuir is a copy of the /descubrir text).

Proposed solution: remove files with translated names from github (once we have fixed the bad translations from the first item above), and implement #1818 so that we can keep translated URLs.

stephanegigandet commented 4 years ago

I deployed the master branch, with the /lang directory on the dev server: https://uk.openfoodfacts.dev https://es.openfoodfacts.dev https://de.openfoodfacts.dev https://it.openfoodfacts.dev

teolemon commented 4 years ago

I started porting your (better) translations to Crowdin.

teolemon commented 4 years ago

2831 is adding variables to the config files so that we can remove language dependant images, urls and often changing numbers from the files.

This reduces risk of bad translations, and reduces retranslations.

github-actions[bot] commented 4 years ago

Stale issue message