openfoodfacts / openfoodfacts-server

Open Food Facts database, API server and web interface - 🐪🦋 Perl, CSS and JS coders welcome 😊 For helping in Python, see Robotoff or taxonomy-editor
GNU Affero General Public License v3.0
633 stars 371 forks source link

Deleting a user on openfoodfacts.org does not delete it on openbeautyfacts.org #5386

Open CharlesNepote opened 3 years ago

CharlesNepote commented 3 years ago

What

hangy commented 3 years ago

The issue is the way that deletion works. https://github.com/openfoodfacts/openfoodfacts-server/blob/bbee9564c088475cd977d4d5df62f9716ed27e6e/lib/ProductOpener/Users.pm#L195

The instances share their users directory through a symlink or something, but https://github.com/openfoodfacts/openfoodfacts-server/blob/15c6cff29263f88a00cb969bd8e789484e5d196e/lib/ProductOpener/Products.pm#L1649 doesn't iterate the configured other_servers https://github.com/openfoodfacts/openfoodfacts-server/blob/bbee9564c088475cd977d4d5df62f9716ed27e6e/lib/ProductOpener/Config_off.pm#L838-L872

github-actions[bot] commented 2 years ago

This issue is stale because it has been open 90 days with no activity.

alexgarel commented 1 year ago

I think a simple way to fix that could be: