openfoodfacts / openfoodfacts-server

Open Food Facts database, API server and web interface - 🐪🦋 Perl, CSS and JS coders welcome 😊 For helping in Python, see Robotoff or taxonomy-editor
http://openfoodfacts.github.io/openfoodfacts-server/
GNU Affero General Public License v3.0
652 stars 381 forks source link

Water should be ignored when computing percent of fruit #7222

Closed alexgarel closed 9 months ago

alexgarel commented 2 years ago

What

If we have a product with this composition (in french): "prune, eau", the estimated percentage of fruit is min:50% which affects the nutriscore, for Fruits‚ vegetables‚ nuts and rapeseed‚ walnut and olive oils (estimate from ingredients list analysis) is then 50%. see: https://world.openfoodfacts.org/product/3760324841617/pruneaux-d-agen-entiers-tres-gros-la-fourche?rev=16

Shouldn't the water be estimated as part of this ? Thus making estimated percentage 100% ?

To Reproduce

see: https://world.openfoodfacts.org/product/3760324841617/pruneaux-d-agen-entiers-tres-gros-la-fourche?rev=16

Expected behavior

Fruits‚ vegetables‚ nuts and rapeseed‚ walnut and olive oils (estimate from ingredients list analysis) should be 100%

Part of

alexgarel commented 2 years ago

cc @stephanegigandet

stephanegigandet commented 2 years ago

Water should not be ignored, the % of fruits is the % of fruits. e.g. a fruit nectar with 25% fruits, sugar 10% and 65% water should have 25% of fruits.

stephanegigandet commented 2 years ago

For https://fr.openfoodfacts.org/produit/3760324841600/pruneaux-d-agen-la-fourche , we should add "Prunes d'Ente" in the ingredients taxonomy though.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 90 days with no activity.

github-actions[bot] commented 9 months ago

This issue has been open 90 days with no activity. Can you give it a little love by linking it to a parent issue, adding relevant labels and projets, creating a mockup if applicable, adding code pointers from https://github.com/openfoodfacts/openfoodfacts-server/blob/main/.github/labeler.yml, giving it a priority, editing the original issue to have a more comprehensive description… Thank you very much for your contribution to 🍊 Open Food Facts

stephanegigandet commented 9 months ago

Closing as the % of fruits is working as specified (not ignoring water).