openfoodfacts / openfoodfacts-server

Open Food Facts database, API server and web interface - 🐪🦋 Perl, CSS and JS coders welcome 😊 For helping in Python, see Robotoff or taxonomy-editor
http://openfoodfacts.github.io/openfoodfacts-server/
GNU Affero General Public License v3.0
654 stars 384 forks source link

NEW DESIGN: products not aligned on first row and last row of lists of products #7309

Open stephanegigandet opened 2 years ago

stephanegigandet commented 2 years ago

https://world.openfoodfacts.dev/

The first products of the first row are slightly off:

image

In the last row, if we have less products than the previous row, it would be good to have them aligned with the previous row:

image

eeshaanSA commented 2 years ago

Would like to take this up. @stephanegigandet

stephanegigandet commented 2 years ago

@eeshaanSA : thank you!

Corresponding code: https://github.com/openfoodfacts/openfoodfacts-server/blob/redesign2/templates/web/pages/product/product_page.tt.html

jainshubham766 commented 2 years ago

I would like to resolve this issue, under hacktoberfeast. Please assign

stephanegigandet commented 2 years ago

I would like to resolve this issue, under hacktoberfeast. Please assign

@jainshubham766 Thanks, I assigned the issue to you.

jainshubham766 commented 2 years ago

@stephanegigandet Can u please specify the file to target? I will help me to resolve fast. Please share how I can run this project locally and debug it.

stephanegigandet commented 2 years ago

@jainshubham766 you can set up the project locally in docker: https://github.com/openfoodfacts/openfoodfacts-server/blob/main/docs/introduction/dev-environment-quick-start-guide.md

The relevant files:

/scss/*.scss /html/js/product-search.js

github-actions[bot] commented 10 months ago

This issue has been open 90 days with no activity. Can you give it a little love by linking it to a parent issue, adding relevant labels and projets, creating a mockup if applicable, adding code pointers from https://github.com/openfoodfacts/openfoodfacts-server/blob/main/.github/labeler.yml, giving it a priority, editing the original issue to have a more comprehensive description… Thank you very much for your contribution to 🍊 Open Food Facts