search

openfoodfacts / openfoodfacts-server

Open Food Facts database, API server and web interface - 🐪🦋 Perl, CSS and JS coders welcome 😊 For helping in Python, see Robotoff or taxonomy-editor
http://openfoodfacts.github.io/openfoodfacts-server/
GNU Affero General Public License v3.0
645 stars 374 forks source link

Move inline JavaScript code out of `import_photos_upload.pl` #7343

Open yuktea opened 2 years ago

yuktea commented 2 years ago

In cgi/import_photos_upload.pl from line 212. There is some inline JS that shouldn't be there. This JavaScript code should ideally be in a new file templates/import_photos_upload.tt.js. an example for refactoring JS out of perl script linked here

aazam-gh commented 2 years ago

Hi, I'd like to work on this issue :)

alexgarel commented 2 years ago

Hi @Alcadeus0 you are welcome ! First think to do might be to setup the project locally, see https://github.com/openfoodfacts/openfoodfacts-server/blob/main/docs/introduction/dev-environment-quick-start-guide.md

aazam-gh commented 2 years ago

Sure I'll look into it today :)

github-actions[bot] commented 9 months ago

This issue has been open 90 days with no activity. Can you give it a little love by linking it to a parent issue, adding relevant labels and projets, creating a mockup if applicable, adding code pointers from https://github.com/openfoodfacts/openfoodfacts-server/blob/main/.github/labeler.yml, giving it a priority, editing the original issue to have a more comprehensive description… Thank you very much for your contribution to 🍊 Open Food Facts