search

openfoodfacts / openfoodfacts-server

Open Food Facts database, API server and web interface - 🐪🦋 Perl, CSS and JS coders welcome 😊 For helping in Python, see Robotoff or taxonomy-editor
GNU Affero General Public License v3.0
629 stars 366 forks source link

Taxonomize stores - Add autosuggest for stores #7632

Open teolemon opened 1 year ago

teolemon commented 1 year ago

What

Part of

CloCkWeRX commented 8 months ago

2011 is heavily related.

Openstreetmap has https://nsi.guide and ~904 supermarket https://nsi.guide/index.html?t=brands&k=shop&v=supermarket brands.

Use case 1: Store names

Use case 2: Store brands

teolemon commented 8 months ago

Raphael O is working on that for Open Prices https://github.com/openfoodfacts/open-prices/pull/38 https://prices.openfoodfacts.org/docs It might be interesting to pool the endpoint with Product Opener @raphael0202

CloCkWeRX commented 8 months ago

Looking at the stores.txt taxinomy, how much does it have to stay in that format?

vs say https://raw.githubusercontent.com/osmlab/name-suggestion-index/main/data/brands/shop/supermarket.json

aleene commented 8 months ago

Better to keep the same format as the other taxonomies.

CloCkWeRX commented 8 months ago

Hmm, may have been superceded by https://github.com/openfoodfacts/taxonomy-editor to a degree

alexgarel commented 7 months ago

https://github.com/openfoodfacts/taxonomy-editor can help maintain the taxonomy, but for now we keep a format. But it's a good reason to keep same format.

Per se, the autosuggest could be instead provided by https://github.com/openfoodfacts/search-a-licious and maybe it's already in the @raphael0202 ?

CloCkWeRX commented 7 months ago

Well, for the short term I've generated it in the taxinomy format in git: https://github.com/openfoodfacts/openfoodfacts-server/pull/9607

Trivial to adjust the generation script to something else.

raphael0202 commented 7 months ago

@alexgarel No it's not included in search-a-licious, it looks like we have an "unofficial" store taxonomy though: https://world.openfoodfacts.org/data/taxonomies/stores.full.json

CloCkWeRX commented 7 months ago

What's the preference re format - /data/taxonomies/stores.full.json or stores.txt.

Happy to enhance either as per https://github.com/openfoodfacts/openfoodfacts-server/pull/9607

raphodn commented 7 months ago

Interesting for https://github.com/openfoodfacts/open-prices !

We're slowly getting dozens of stores with OFF products : https://prices.openfoodfacts.org/app/locations

teolemon commented 7 months ago

@raphodn @raphael0202 @CloCkWeRX Please add a 👍 to the issue, so that it gets into popular issues

CloCkWeRX commented 7 months ago

@teolemon - I'd be keen on PR feedback instead. https://github.com/openfoodfacts/openfoodfacts-server/pull/9607 - if it's the wrong approach, okay, what's the right one these days?