Open CharlesNepote opened 1 year ago
Why not only obsolete_since_date only ? Empty means it's not obsolete.
Why not only obsolete_since_date only ? Empty means it's not obsolete.
There is this case where an EAN could be abandoned at a given date and reused years afters -- so we could have "obsolete": "off"
and "obsolete_since_date": "2023/07/01"
but it's a bit weird and even confusing...
So I think obsolete_since_date
should make it, indeed.
This issue has been open 90 days with no activity. Can you give it a little love by linking it to a parent issue, adding relevant labels and projets, creating a mockup if applicable, adding code pointers from https://github.com/openfoodfacts/openfoodfacts-server/blob/main/.github/labeler.yml, giving it a priority, editing the original issue to have a more comprehensive description… Thank you very much for your contribution to 🍊 Open Food Facts
Can I work on this issue?
Note that there might be some conflicts with #9684, as both issues are about the same export script
There is also a similar issue #8338 where the idea would be to do seperate CSV/JSONL exports for obsolete products, as they are stored in a seperate database
Obsolete products are exported into the CSV daily export, which is a good thing, but in the CSV export there are no data at all to identify the products which are obsoletes. This information can be interesting for many use cases:
In the JSON API, there are these values:
(Example.)
We could export in the CSV file:
"obsolete": "on"
for a minimal information"obsolete": "on"
and"obsolete_since_date": "2023/07/01"
to allow monitoring obsolete products.I would in favor of the second option.
Part of
8814
6429