openfoodfacts / openfoodfacts-server

Open Food Facts database, API server and web interface - 🐪🦋 Perl, CSS and JS coders welcome 😊 For helping in Python, see Robotoff or taxonomy-editor
http://openfoodfacts.github.io/openfoodfacts-server/
GNU Affero General Public License v3.0
657 stars 384 forks source link

Monitoring data changes #9777

Open aleene opened 8 months ago

aleene commented 8 months ago

What

I am trying to look at all data quality errors for the Netherlands, in order to see how many can repaired and to know the intrinsic errors made my producers on packages.

So I look at the page with errors: https://nl.openfoodfacts.org/data-quality-errors and go through all products. If a product is done I add a checkmark on the checkmarks at the bottom: images have been checked:

Screenshot 2024-02-09 at 09 32 47

After doing a initial run through all the products I like to follow any newly introduced erros by looking at: https://nl.openfoodfacts.org/status/-foto-s-gecontroleerd/data-quality-errors/ This is the same a the previous list but now enhances with the facet photos checked not checked (made negative with a "-").

This does not work. Why not?

Steps to reproduce the behaviour

see the list

Expected behaviour

I like to see only the products that I did not look atr

himanshisrestha commented 7 months ago

is this issue is only visible on the pro platform , I was not able to view the issue after clicking the link. @aleene

aleene commented 7 months ago

Not sure this solved or not. It might be related to the cache that has some issues.

aleene commented 7 months ago

is this issue is only visible on the pro platform

It is nothing to do with the pro platform. It is about the usage of the checkbox 'product has been checked'

aleene commented 3 weeks ago

The example given is for monitoring data quality errors, but is valid for any set of products. Once a product is set to checked we would like to know if any changes are made, either simple edits or new images. This might require to look at the product again. Thus we can keep an eye on product groups (categories, quality errors, products created since a date, etc.). In the code the value for checked is linked to the state for completed:

if ($complete) {
        push @states_tags, "en:complete";
        if ((defined $product_ref->{checked}) and ($product_ref->{checked} eq 'on')) {
            push @states_tags, "en:checked";
        }
        else {
            push @states_tags, "en:to-be-checked";
        }
    }
    else {
        push @states_tags, "en:to-be-completed";
    }

My proposal is to decouple these states. Completed is to specify that all the data (which) has been filled in; Checked is to specify that all possible data has been extracted from the images.