Create the elastic search query in a more precise and flexible way - Githubissues

openfoodfacts / search-a-licious

🍊🔎 A pluggable search service for large collections of objects (like Open Food Facts)

https://search.openfoodfacts.org

GNU Affero General Public License v3.0

6 stars 4 forks source link

Create the elastic search query in a more precise and flexible way #117

Open alexgarel opened 1 month ago

alexgarel commented 1 month ago

What

Right now we extract bare words from the query in unknown operation and filter them out to treat them separately.
But the implementation is quite faulty:
- at least we should harvest words as we remove them from expressions
- we should verify in the transformer if we are in a SearchTerm or not !

Proposed solution

But if we want to support complex expressions, instead of separating bare words, we should specialize the elastic search query builder so that it handles our bare words using our target expression.
Also we should support Phrase, not only Word.

Part of

62

alexgarel commented 1 month ago

I changed the implementation to be more straightforward while keeping the full text term / filters separation.

It's good enough for now but this ticket will be kept open because the good solution is to correctly change the Word search as we transform the tree to an ES query.