openfoodfacts / smooth-app

🤳🥫 The new Open Food Facts mobile application for Android and iOS, crafted with Flutter and Dart
https://world.openfoodfacts.org/open-food-facts-mobile-app?utm_source=off&utf_medium=web&utm_campaign=github-repo
Apache License 2.0
831 stars 278 forks source link

Offer to save Open Food Facts credentials in the native OS keychains #1344

Closed teolemon closed 2 years ago

teolemon commented 2 years ago

What

Part of

M123-dev commented 2 years ago

Already done 😉 https://github.com/openfoodfacts/smooth-app/blob/develop/packages/smooth_app/lib/database/dao_secured_string.dart

teolemon commented 2 years ago

@M123-dev for some reason it's not offering the saved credentials when I try to login again

M123-dev commented 2 years ago

What do you mean @teolemon, autocomplete from your keyboard

teolemon commented 2 years ago

It might be an Android specific feature: https://pub.dev/packages/password_credential

M123-dev commented 2 years ago

Actually autocomplete should be already in the TextFields for login/register. Creating a new issue

g123k commented 2 years ago

We don't need to store this kind of information. We have the autofill feature for that