Overflow at update nutrition facts page

openfoodfacts / smooth-app

🤳🥫 The new Open Food Facts mobile application for Android and iOS, crafted with Flutter and Dart

https://world.openfoodfacts.org/open-food-facts-mobile-app?utm_source=off&utf_medium=web&utm_campaign=github-repo

Apache License 2.0

800 stars 275 forks source link

Overflow at update nutrition facts page #1508

Closed bhattabhi013 closed 2 years ago

bhattabhi013 commented 2 years ago

What

Overflow at update nutrition facts page

Steps to reproduce the behavior

Search any product.
Click on 'update nutrition facts'
See overflow error on the header.

Expected behavior

The overflow should not happen.

Screenshot/Mockup/Before-After

Smartphone model

Device: [Real me 5 pro]
OS: [Android 10]
App Version [e.g. 22] - you can see that either in the About Smoothie dialog in the settings or using https://nerdschalk.com/how-to-find-version-number-of-an-app-installed-on-your-device/

monsieurtanuki commented 2 years ago

Probably again an AutoSize related bug solving, like #1506 and #1503 cc @abhay1821

abhay1821 commented 2 years ago

Indeed @monsieurtanuki, AutoSIze Widget can help to improve all the issues.

bhattabhi013 commented 2 years ago

Hi @monsieurtanuki @abhay1821 , I feel that it is not due to the autosize widget as it is not used here and is caused by #1475. I used a sized box and it fixes this. Here is a screenshot of it.

abhay1821 commented 2 years ago

Yes, you are correct @bhattabhi013 it's not due to autosize text. What @monsieurtanuki And I meant is now we have AutoSizeText Widget in our App so we can play around with AutoSizeText for overflow-related Issues. So here we can use AutoSIzeText with maxlines=2.

bhattabhi013 commented 2 years ago

Thanks @abhay1821 , I got it now. If you don't mind can I work on this one?

abhay1821 commented 2 years ago

Yeah Sure, go ahead @bhattabhi013.

bhattabhi013 commented 2 years ago

This issue is fixed by #1509