search

openfoodfacts / smooth-app

🤳🥫 The new Open Food Facts mobile application for Android and iOS, crafted with Flutter and Dart
https://world.openfoodfacts.org/open-food-facts-mobile-app?utm_source=off&utf_medium=web&utm_campaign=github-repo
Apache License 2.0
853 stars 282 forks source link

Make app_name untranslatable #1747

Closed teolemon closed 2 years ago

teolemon commented 2 years ago

What

M123-dev commented 2 years ago

Should it be moved out of translations completely or what is the plan

teolemon commented 2 years ago

I've made manual corrections in Crowdin for the time being, but to avoid future mistakes, I would like it to be moved out of translations, yes, or marked untranslatable if the *.arb syntax/flutter intl mechanism allows to do so

teolemon commented 2 years ago

It's not a blocker, since being careful on translation merges should prevent this potential problem from happening

monsieurtanuki commented 2 years ago

Or just putting 'OpenFoodFacts' in a static const and not using localizations like .app_name.

AshAman999 commented 2 years ago

Since app has been renamed to smoothie is it okay to reference it with smoothie in the readme ? (Just asking)

M123-dev commented 2 years ago

@teolemon ?

I'd say it's good to keep it as codename for the devs but not in interactions with users