Edit Retake Confirm button stacking on the left side

openfoodfacts / smooth-app

🤳🥫 The new Open Food Facts mobile application for Android and iOS, crafted with Flutter and Dart

https://world.openfoodfacts.org/open-food-facts-mobile-app?utm_source=off&utf_medium=web&utm_campaign=github-repo

Apache License 2.0

790 stars 271 forks source link

Edit Retake Confirm button stacking on the left side #2184

Closed M123-dev closed 2 years ago

M123-dev commented 2 years ago

What

I don't know if the vertical stacking is wanted behavior, but if then they should stack on the right side of the screen to have a comment gesture with FloatingActionButtons

Part of

Photo manager

teolemon commented 2 years ago

This retake photo flow is too complex at the core. From V1, contributors expect direct access to the Retake photo button. We currently hide it behind 3 taps (one to go to gallery, one on edit button, one on the checkbox, with 0 clue that's a potential path to retake a photo, and one final tap on Retake photo)
How complicated is it to refactor it to make photo retake much more accessible ?
It's a much more common use case than recropping.
Also, we're doing client side cropping on existing photos and reuploading them while we should be doing server side cropping, to improve performance even with low connectivity.

AshAman999 commented 2 years ago

@M123-dev The stacking wasn't expected, I just looked up, it seems like when there is no space to fi the buttons in the horizontal space it tries to fit it in the stacked layout.

Looking into this..

AshAman999 commented 2 years ago

What about this ? cc @M123-dev

AshAman999 commented 2 years ago

Tried to reduce the steps to capture a new image...

https://user-images.githubusercontent.com/57723319/172160798-8d631509-4681-43e2-bd98-643fc0fbf576.mp4

M123-dev commented 2 years ago

Yess looks better this way @AshAman999, when the buttons stay in a row if there is enouph space that would be perfect. Wrap would be the right widget here.