openfoodfacts / smooth-app

🤳🥫 The new Open Food Facts mobile application for Android and iOS, crafted with Flutter and Dart
https://world.openfoodfacts.org/open-food-facts-mobile-app?utm_source=off&utf_medium=web&utm_campaign=github-repo
Apache License 2.0
820 stars 278 forks source link

Close button not working properly on Product search Page #2729

Closed abughalib closed 2 years ago

abughalib commented 2 years ago

What

The close button on the product scan page is not closing the dialog

Steps to reproduce the behavior

  1. Go to Search
  2. Search for any product
  3. Scroll down and click on Close

Screen Recording

https://user-images.githubusercontent.com/33085535/183059612-2bbb6fa9-3bb7-4de6-987d-bd60d8d12cef.mp4

Smartphone model

monsieurtanuki commented 2 years ago

Thank you @abughalib for having detected this bug. Strange, it didn't happen when I coded it. That said, I think I'll get rid of the "close" button: no error then ;) And put the banner in a sliver instead. Because anyway, it was a bit strange (assuming that the close button works, yes it did), that when you close the banner and then say "hey, finally I would like world data" you could not anymore as the banner was dismissed.

monsieurtanuki commented 2 years ago

Working on a more simple version. Should be ready tomorrow. Capture d’écran 2022-08-05 à 21 26 35

monsieurtanuki commented 2 years ago

And that gives me the opportunity to improve the "empty screen" too: Capture d’écran 2022-08-05 à 22 09 12