openfoodfacts / smooth-app

🤳🥫 The new Open Food Facts mobile application for Android and iOS, crafted with Flutter and Dart
https://world.openfoodfacts.org/open-food-facts-mobile-app?utm_source=off&utf_medium=web&utm_campaign=github-repo
Apache License 2.0
835 stars 279 forks source link

Revamp proposal for the nutrition table #3136

Open g123k opened 2 years ago

g123k commented 2 years ago

What

Hence, my proposal:

Feel free to share your comments :)

Part of

monsieurtanuki commented 2 years ago

@g123k Your suggestion looks great!

My remarks:

  1. as you know off-dart does not support < > for the moment, so that column is not relevant (yet)
  2. the units take too much space for little added value - given the low frequency when a user changes the unit, we would be better off with only one unit and a button
  3. in a near future, we'll have to handle not only "product as sold" data (the standard nutrition table), but also "product as prepared" (e.g. for cocoa powder when mixed with milk), cf. #3046, and it would be great if you could take that into consideration in your design
  4. there's no "save" button in your screen - I think it should always be visible
teolemon commented 2 years ago

What happens on narrow screens, and with prepared scrolling ? Does it scroll sideways ?

teolemon commented 2 years ago

Also personal opinion: the table looks intimidating. Very precise, but a bit intimidating (I'm going to break something)

VaiTon commented 2 years ago

I really like the table design. It's clear and resembles the one on the packaging.

there's no "save" button in your screen - I think it should always be visible

The save button could be put as an action button on the appbar!

For the rest, I'm with @monsieurtanuki

monsieurtanuki commented 2 years ago

@g123k Btw I'm currently refactoring the nutriment page: nothing about the display, but as an impact of https://github.com/openfoodfacts/openfoodfacts-dart/pull/570

galnaf commented 2 years ago

What if the serving size is not 100 gr. Would there be a way to enter it manually?

g123k commented 2 years ago

What if the serving size is not 100 gr. Would there be a way to enter it manually?

Yes, that the "serving size" field