openfoodfacts / smooth-app

🤳🥫 The new Open Food Facts mobile application for Android and iOS, crafted with Flutter and Dart
https://world.openfoodfacts.org/open-food-facts-mobile-app?utm_source=off&utf_medium=web&utm_campaign=github-repo
Apache License 2.0
844 stars 282 forks source link

Add shortcuts for Hunger Games, Product to Be Completed list #3236

Open teolemon opened 2 years ago

teolemon commented 2 years ago

Problem

Proposed solution

Part of

omkarChend1kar commented 1 year ago

@teolemon There are three tabs in bottom nav bar ,Only possible screen I can think of is Profile screen ,So where exactly are intending to put these shortcut ,One thing I can think of is, We can put floating action buttons on right bottom corner on profile screen itself.

teolemon commented 1 year ago

Screenshot_20221112-174508.png

teolemon commented 1 year ago

This is not a shortcut within the app, this would be a shortcut from your android home screen

omkarChend1kar commented 1 year ago

Understood

omkarChend1kar commented 1 year ago

I have found couple of plugins which could get this done for us, There are two plugins which could exactly helps us for this enhancements

There is also one another thing that I found, Quick actions which is somewhat different, In this user have to long press on app icon to get required shortcuts, This can be implemented using following plugin itself :

image

Although, I would like to know your views on whether we can use these plugins or we should go with the Method Channels implementation from scratch.

M123-dev commented 1 year ago

Here goes the same thing as with similar issues, we likely need Navigator V2 for this

921

920

Although, I would like to know your views on whether we can use these plugins or we should go with the Method Channels implementation from scratch.

@g123k is likely the one to have a preferece here

monsieurtanuki commented 1 year ago

@M123-dev @g123k I have good news about Navigator V2.

Around #3018, part of the solution is not to wait for an answer when you open a new page.

Typically, we used to say "open that page and get the product as a result" (and that was not compliant with deep-linking).

When #3018 is completed, we'll never expect a page to return anything. If the page "succeeds", it will mean that it has

teolemon commented 1 year ago

Also @omkarChend1kar this is not shortcuts on the main icon. As the screenshot shows, this is the ability to add additional icons to some parts of the app (or even specific lists). I believe it's an Android only feature, called pinned shortcuts. https://developer.android.com/develop/ui/views/launch/shortcuts/creating-shortcuts#pinned

omkarChend1kar commented 1 year ago

Also @omkarChend1kar this is not shortcuts on the main icon. As the screenshot shows, this is the ability to add additional icons to some parts of the app (or even specific lists). I believe it's an Android only feature, called pinned shortcuts. https://developer.android.com/develop/ui/views/launch/shortcuts/creating-shortcuts#pinned

Yeah, I am aware about that ,I thought mentioning it might be useful for this kind of usecase.

omkarChend1kar commented 1 year ago

Here goes the same thing as with similar issues, we likely need Navigator V2 for this

921 #920

Although, I would like to know your views on whether we can use these plugins or we should go with the Method Channels implementation from scratch.

@g123k is likely the one to have a preferece here

Okay

g123k commented 1 year ago

@teolemon Pinned shortcuts are the equivalent of iOS force touch feature. The only question is here: do you want dynamic items (eg: a direction to a custom list) or some hard coded lists.

Depending on that, the implementation may differ.