openfoodfacts / smooth-app

🤳🥫 The new Open Food Facts mobile application for Android and iOS, crafted with Flutter and Dart
https://world.openfoodfacts.org/open-food-facts-mobile-app?utm_source=off&utf_medium=web&utm_campaign=github-repo
Apache License 2.0
840 stars 281 forks source link

Nutritional information disappears after saving #3469

Open Duckbilled opened 1 year ago

Duckbilled commented 1 year ago

On the iOS app, after saving the nutritional information it disappears when getting out of the nutritional input page.

28CB6408-FBB9-40EF-905D-9684CB77814A

M123-dev commented 1 year ago

Heyyy @Duckbilled thanks for the report, I myself don't have iOS so I can't check this, but could you check two things regarding this problem?

  1. Check if you are able to create new products (you can just type in random numbers in search if you don't have a product around, naming it "test" or something like that is fine)
  2. Try the Nutritional information problem with analytics disabled in the settings
Duckbilled commented 1 year ago

I can create a new product (although I seem to only be able to add photos at first and not edit information (but I guess that is by design).

M123-dev commented 1 year ago

Yeah, it's just the basic details and images, that's because there is a lot that can be extracted from the images because of that they have a high priority. It's great to hear that you are able to create new products 👍🏼

AshAman999 commented 1 year ago

Hello @Duckbilled I was trying to recreate the same bug on iOS 16 but wasn't able to I did with my settings allowed for analytic and once off in both cases I can't seem to reproduce the issue,

Can I get more details about settings and device language app language,app country etc.

One more question can you tell us the app gestures or whether you are using the ios store all or trying the TestFlight beta?

M123-dev commented 1 year ago

Also could you check if they appear after a few (2 - not more then 10minutes)

And does manual refreshing work

monsieurtanuki commented 1 year ago

Hi @Duckbilled!

There's a possible little confusion here:

In addition to that, there are open issues (e.g. #3466) that may explain discrepancies between the app and the server.

To sum up, I would suggest to check different places:

There's probably a bug, but we need you to check the coherence of those 3 places in order to understand it.

AshAman999 commented 1 year ago

Also could you check if they appear after a few (2 - not more then 10minutes)

And does manual refreshing work

For me everything worker smooth, i tried my best to recreate the issue but not able to

Since we are to check the return status for the actions done,i think in addition if it fails we can log that to sentry, that might help us understand better the things here.

Sorry I had a busy week,would get back to complete #3466 soon with few tweaks.

Duckbilled commented 1 year ago

Thank you all for the quick responses!

@monsieurtanuki, I was aware the picture was from the product page and indeed it looks like a case for frustration 3. When I checked just a little earlier I saw the new data is available, but only quiet a while after the first entry of the info. @M123-dev, at least a couple of hours after entry it was not visible yet. I haven't checked earlier today, but at midday-ish I saw new info in the product page.

In this case there might be room to improve on some UX. I saw a little banner at the bottom, but it is not really helpful (it stated the 10-15 minutes M123 mentioned). Another improvement might be if it would be able to save my entry on device. So that when I go back in to the entry form, my digits are still present (+a banner stating I have entered data earlier and whether I want to change it again, or otherwise a polite message telling me to be patient).

I really enjoy this project, awesome work! And the new app looks really good!

monsieurtanuki commented 1 year ago

Another improvement might be if it would be able to save my entry on device. So that when I go back in to the entry form, my digits are still present

@Duckbilled That's exactly how it works. As long as the data is not sent to the server, it is stored locally and displayed on top of the "clean" server data. And we're not talking about 15 minutes to call the server, but less than a minute.

We need to improve the UX anyway.