search

openfoodfacts / smooth-app

🤳🥫 The new Open Food Facts mobile application for Android and iOS, crafted with Flutter and Dart
https://world.openfoodfacts.org/open-food-facts-mobile-app?utm_source=off&utf_medium=web&utm_campaign=github-repo
Apache License 2.0
851 stars 282 forks source link

Website Column Text Overflow needs Wrap #3575

Closed Akashsri3bi closed 1 year ago

Akashsri3bi commented 1 year ago

What

Website Column Text Overflow needs Wrap

Screenshot_2023-01-16-13-45-54-83

Akashsri3bi commented 1 year ago

Will fix it ! No worries

monsieurtanuki commented 1 year ago

@Akashsri3bi We probably don't care about the full address being printed, so "ellipsis" on just one line would make more sense than "wrap" / multiline.

Akashsri3bi commented 1 year ago

Great Sure @monsieurtanuki !

monsieurtanuki commented 1 year ago

For rhe record we're not the only ones with layout issues ;) Screenshot_2023-01-16-09-39-32

Akashsri3bi commented 1 year ago

Ha ha , Ya ;)

monsieurtanuki commented 1 year ago

Hi @Akashsri3bi!

Let me remind you that you're supposed to put a "Closes: #issue_number" in the pull request (cf. #3607): this way the issue is automatically closed after the PR is merged. Alternate solution: close it now! ;)

By the way, do you have a barcode with a long website url, just to have a look at the result - you didn't provide screenshots either...

Akashsri3bi commented 1 year ago

Hi @Akashsri3bi!

Let me remind you that you're supposed to put a "Closes: #issue_number" in the pull request (cf. #3607): this way the issue is automatically closed after the PR is merged. Alternate solution: close it now! ;)

By the way, do you have a barcode with a long website url, just to have a look at the result - you didn't provide screenshots either...

I checked it with a long url , It ellipses with three dots . Ya I totally forgot to put a screenshot but it works fine . Closing Issue Thanks for reminders I will take care now onwards