[Bug?] Inconsistent colors on the product page

openfoodfacts / smooth-app

🤳🥫 The new Open Food Facts mobile application for Android and iOS, crafted with Flutter and Dart

https://world.openfoodfacts.org/open-food-facts-mobile-app?utm_source=off&utf_medium=web&utm_campaign=github-repo

Apache License 2.0

861 stars 286 forks source link

[Bug?] Inconsistent colors on the product page #4011

Open g123k opened 1 year ago

g123k commented 1 year ago

Hi everyone,

This is the first time I've clearly noticed the issue, but why do we use multiples tones of red/green/orange on the product page?

monsieurtanuki commented 1 year ago

@g123k you may be right in some cases, but keep in mind that some "colored icons" are provided by the server (e.g. Nova, perhaps vegetarian) and some are just a monochromous svg that we tint. Please have a look at "cache" and "tinted" asset folders. But for the colored disks we should probably use the same values for red and green, indeed.

teolemon commented 1 year ago

Very nice catch. green: 60ef00, 00aa02, 61ac11 red: eb5757, f00000

teolemon commented 1 year ago

I'm looking at the Figma file. Tim had put some colors, Quentin had pastellized them. Stéphane has designed some other stuff with his own colors.
I've opened a similar issue server side: https://github.com/openfoodfacts/openfoodfacts-server/issues/8458

g123k commented 1 year ago

So what's the best way to fix it? For on the server-side and then here?